Fix HASH vector fetch decoding and score normalization#2
Open
Fix HASH vector fetch decoding and score normalization#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
number[]values instead of raw binary-looking payloadsnormalizeDistance: truereturns similarity-style scores consistentlyValidation
npm run format:checknpm run lintnpm run type-checknpm run buildnpm run test -- tests/unit/indexes/search-index.test.tsnpm run test -- tests/integration/search-index.test.tsCI Notes
.github/workflows/lint.ymland ran the local equivalents:npm run format:check,npm run lint, andnpm run type-check.github/workflows/test.ymland ran focused local equivalents for the changed surface:npm run build,npm run test -- tests/unit/indexes/search-index.test.ts, andnpm run test -- tests/integration/search-index.test.tstests/unit,tests/integration, fullnpm test) on Node 22/24 and Redis variants; those were not fully re-run locally because the touched surface is narrower than the full matrix