fix: shell-escape dynamic values in pagination hint#210
Draft
bukinoshita wants to merge 2 commits intomainfrom
Draft
fix: shell-escape dynamic values in pagination hint#210bukinoshita wants to merge 2 commits intomainfrom
bukinoshita wants to merge 2 commits intomainfrom
Conversation
printPaginationHint() was interpolating --profile, --api-key, and cursor values directly into a copy-pasteable shell command without escaping. A malicious --profile value containing shell metacharacters would be reflected verbatim, allowing injection if the user copy-pasted the hint. Add shQuote() (POSIX single-quote escaping) and apply it to all dynamic arguments rendered in the pagination hint command. Resolves BU-633 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/lib/pagination.ts">
<violation number="1" location="src/lib/pagination.ts:59">
P2: Use `!== undefined` for Commander option presence instead of truthiness so explicitly provided empty-string values are not dropped from the generated hint.
(Based on your team's feedback about checking Commander option presence with `!== undefined`.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| const limitFlag = opts.limit ? ` --limit ${opts.limit}` : ''; | ||
| const apiKeyFlag = opts.apiKey ? ` --api-key ${maskKey(opts.apiKey)}` : ''; | ||
| const profileFlag = opts.profile ? ` --profile ${opts.profile}` : ''; | ||
| const apiKeyFlag = opts.apiKey |
Contributor
There was a problem hiding this comment.
P2: Use !== undefined for Commander option presence instead of truthiness so explicitly provided empty-string values are not dropped from the generated hint.
(Based on your team's feedback about checking Commander option presence with !== undefined.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/pagination.ts, line 59:
<comment>Use `!== undefined` for Commander option presence instead of truthiness so explicitly provided empty-string values are not dropped from the generated hint.
(Based on your team's feedback about checking Commander option presence with `!== undefined`.) </comment>
<file context>
@@ -55,10 +56,12 @@ export function printPaginationHint(
const limitFlag = opts.limit ? ` --limit ${opts.limit}` : '';
- const apiKeyFlag = opts.apiKey ? ` --api-key ${maskKey(opts.apiKey)}` : '';
- const profileFlag = opts.profile ? ` --profile ${opts.profile}` : '';
+ const apiKeyFlag = opts.apiKey
+ ? ` --api-key ${shQuote(maskKey(opts.apiKey))}`
+ : '';
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Escapes dynamic values in the pagination hint using POSIX single-quote rules to prevent shell injection in copy-pasteable commands. Resolves BU-633 by safely quoting cursor, masked API key, and profile values.
shQuoteutility for POSIX single-quote escaping.printPaginationHintfor cursor,--api-key, and--profile.Written for commit 72af19d. Summary will update on new commits.