Skip to content

[Yield] Support invocations to yield on transient errors#4725

Open
AhmedSoliman wants to merge 1 commit into
mainfrom
pr4725
Open

[Yield] Support invocations to yield on transient errors#4725
AhmedSoliman wants to merge 1 commit into
mainfrom
pr4725

Conversation

@AhmedSoliman
Copy link
Copy Markdown
Contributor

@AhmedSoliman AhmedSoliman commented May 12, 2026

Full implementation for yielding invocations from the invoker back to the vqueues scheduler. This unifies with the existing support for memory-budget-based invocation yielding.


Stack created with Sapling. Best reviewed with ReviewStack.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

Test Results

  8 files  + 1    8 suites  +1   4m 42s ⏱️ + 2m 4s
 50 tests + 3   50 ✅ + 3  0 💤 ±0  0 ❌ ±0 
218 runs  +18  218 ✅ +18  0 💤 ±0  0 ❌ ±0 

Results for commit 3c4e111. ± Comparison against base commit 4b67ea3.

This pull request removes 4 and adds 7 tests. Note that renamed tests count towards both.
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInCounterService(URI, int, Client)
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInEventHandler(URI, int, Client)
dev.restate.sdktesting.tests.UpgradeWithInFlightInvocation ‑ inFlightInvocation(Client, URI)
dev.restate.sdktesting.tests.UpgradeWithNewInvocation ‑ executesNewInvocationWithLatestServiceRevisions(Client, URI)
dev.restate.sdktesting.tests.Combinators ‑ awakeableOrTimeoutUsingAwaitAny(Client)
dev.restate.sdktesting.tests.Combinators ‑ firstSuccessfulCompletedAwakeable(Client)
dev.restate.sdktesting.tests.Custom ‑ run(CustomTestConfig, URI, URI)[1]
dev.restate.sdktesting.tests.UserErrors ‑ failSeveralTimesWithMetadata(URI)
dev.restate.sdktesting.tests.UserErrors ‑ internalCallFailurePropagationWithMetadata(URI)
dev.restate.sdktesting.tests.UserErrors ‑ invokeTerminallyFailingCallWithMetadata(URI)
dev.restate.sdktesting.tests.UserErrors ‑ sideEffectWithTerminalErrorWithMetadata(URI)

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman changed the title [Yield][1/N] Introduce Effect Yield for errors [Yield] Support invocations to yield on transient errors May 13, 2026
@AhmedSoliman AhmedSoliman marked this pull request as ready for review May 13, 2026 15:03
@AhmedSoliman AhmedSoliman requested a review from tillrohrmann May 13, 2026 16:41
@AhmedSoliman AhmedSoliman force-pushed the pr4725 branch 2 times, most recently from b824fb7 to c8ebcb2 Compare May 13, 2026 17:09
Full implementation for yielding invocations from the invoker back to the vqueues scheduler. This unifies with the existing support for memory-budget-based invocation yielding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant