Add ParallelFileTask for parallel file processing#11
Merged
Conversation
- Import `concurrent.futures` in `task.py`
- Introduce new class `ParallelFileTask` extending `RomiTask`
- New luigi parameters: `query`, `n_workers`, `parallel`
- Abstract method `f` to be implemented by subclasses
- `run` method:
- Retrieves input files with `query`
- Copies metadata from input to output files
- Supports sequential processing when `parallel` is disabled
- Enables parallel execution using `ThreadPoolExecutor` and `tqdm` when enabled
- Handles `n_workers` = -1 to use default thread pool size
- Uses helper `_process_file` to encapsulate per‑file logic and metadata handling
ArthurLuciani2
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
ParallelFileTask, a newRomiTasksubclass that enables parallel processing of files using a thread pool and progress tracking.Key Changes
concurrent.futuresintask.py.ParallelFileTaskwith new Luigi parameters:query: pattern to locate input files.n_workers: number of worker threads (-1uses the default pool size).parallel: flag to enable/disable parallel execution.ffor subclasses to implement the per‑file operation.runmethod that:query.parallel=False.ThreadPoolExecutorandtqdmwhenparallel=True._process_fileto encapsulate per‑file logic and metadata handling.