Skip to content

Avoid duplicate diagnostic args in RegionOriginNote::WithName#154875

Open
TaKO8Ki wants to merge 1 commit intorust-lang:mainfrom
TaKO8Ki:regression-test-152936-regions-name
Open

Avoid duplicate diagnostic args in RegionOriginNote::WithName#154875
TaKO8Ki wants to merge 1 commit intorust-lang:mainfrom
TaKO8Ki:regression-test-152936-regions-name

Conversation

@TaKO8Ki
Copy link
Copy Markdown
Member

@TaKO8Ki TaKO8Ki commented Apr 6, 2026

Fixes #152936

This is a follow up to #153508.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 10 candidates

@TaKO8Ki TaKO8Ki changed the title Add regions regression test for impl-trait lifetime conflict Add regression test for impl-trait lifetime conflict 152936 Apr 6, 2026
@rust-log-analyzer

This comment has been minimized.

@TaKO8Ki TaKO8Ki force-pushed the regression-test-152936-regions-name branch from 9e11eee to f497faf Compare April 6, 2026 09:31
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

@TaKO8Ki
Copy link
Copy Markdown
Member Author

TaKO8Ki commented Apr 6, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2026
@TaKO8Ki TaKO8Ki force-pushed the regression-test-152936-regions-name branch from f497faf to 989f4cd Compare April 6, 2026 12:06
@TaKO8Ki TaKO8Ki changed the title Add regression test for impl-trait lifetime conflict 152936 Avoid duplicate diagnostic args in RegionOriginNote::WithName Apr 6, 2026
@TaKO8Ki
Copy link
Copy Markdown
Member Author

TaKO8Ki commented Apr 6, 2026

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: arg name already exists

4 participants