Conversation
|
Claude finished @binoy14's task in 4m 33s —— View job Review
} else if (appHost) {
uri = `/projects/${projectId}/user-applications`
query = {appHost, appType: 'studio'}
} else {
uri = `/projects/${projectId}/user-applications` // ← no query params, no appType
}When
|
Coverage Delta
Comparing 2 changed files against main @ Overall Coverage
|
4c751af to
7f352e7
Compare
- Wrap deleteUserApplication in try/catch so spinner fails properly on error - Add test for delete API failure (500 response) - Add missing 'Remember to remove' assertion on prioritizes deployment.appId test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Narrow `err` to `Error | string` in promptForApplication catch block - Distinguish null (API error) from empty array in getUserApplications - Fix misleading "not been assigned" message when configured host doesn't exist - Add test for app listing API failure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove explicit {exit: 1} from app listing error to default to 2,
matching the studio path behavior
- Add test for studio listing API failure in interactive mode
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove double error handling in promptForApplication by delegating directly to promptForApp/promptForStudio. Add try/catch in both prompt methods for consistent error handling and fix variable naming bug. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use spin.info() instead of spin.fail() for empty app/studio lists since an empty result is not an error - Remove error swallowing in getUserApplications for coreApp so server errors propagate with their original message - Fix implementation return type to match overloads (no more | null) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use getAppId() for the "remember to remove" check so it also triggers for the deprecated app.id config path - Remove redundant this.parse() call since init() already populates flags - Add explicit assertions to the rejection-after-selection test - Add test for deprecated app.id showing the reminder message Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Show the right config key in the reminder message depending on whether
deployment.appId or the deprecated app.id is set
- Remove unreachable {default: 'true'} fallback in getUserApplication
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix type error from removing ternary in getUserApplication by using proper branching for appHost - Remove dead isSdkApp URI fallback (appId is required by the type) - Use spin.info() consistently for missing config (orgId, projectId) instead of spin.fail() + this.log() - Add test for studio deployment.appId with missing projectId Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1dcda15 to
e65f853
Compare
📦 Bundle Stats —
|
| Metric | Value | vs main (c37431d) | vs v6.2.1 |
|---|---|---|---|
| Internal (raw) | 2.1 KB | - | - |
| Internal (gzip) | 799 B | - | - |
| Bundled (raw) | 11.06 MB | - | +9.12 MB, +470.6% |
| Bundled (gzip) | 2.07 MB | - | +1.60 MB, +335.8% |
| Import time | 863ms | +5ms, +0.6% | +34ms, +4.1% |
bin:sanity
| Metric | Value | vs main (c37431d) | vs v6.2.1 |
|---|---|---|---|
| Internal (raw) | 975 B | - | - |
| Internal (gzip) | 460 B | - | - |
| Bundled (raw) | 9.83 MB | - | +9.12 MB, +1286.7% |
| Bundled (gzip) | 1.77 MB | - | +1.60 MB, +940.0% |
| Import time | NaNs | - | NaNs, NaN% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (c37431d6) · v1.2.1 (npm)
| Metric | Value | vs main (c37431d) | vs v1.2.1 |
|---|---|---|---|
| Internal (raw) | 92.2 KB | - | +3.9 KB, +4.4% |
| Internal (gzip) | 21.6 KB | - | +1.1 KB, +5.5% |
| Bundled (raw) | 21.72 MB | - | +9.16 MB, +72.9% |
| Bundled (gzip) | 3.45 MB | - | +1.61 MB, +87.2% |
| Import time | 816ms | +7ms, +0.8% | +54ms, +7.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Coverage Delta
Comparing 2 changed files against main @ Overall Coverage
|
Description
Not urgent, new behavior.
Sort of annoying that if you deploy a studio/app and don't remember/see to put the appId into your CLI config,
undeployjust… doesn't work. Now, if there's noappIdspecified, we allow the user to select from a list of apps. If it detects that you're in an app folder, it will give you app choices. If you're in a studio folder, it will give you studios.Prompts before actually undeploying.
What to review
Do the flows make sense?
Flowchart:
Testing
Added new tests for the new behavior