rust(feat): Updated Rust CLI Parquet imports to detect config on clientside#541
Draft
Brandon-Shippy wants to merge 2 commits intomainfrom
Draft
rust(feat): Updated Rust CLI Parquet imports to detect config on clientside#541Brandon-Shippy wants to merge 2 commits intomainfrom
Brandon-Shippy wants to merge 2 commits intomainfrom
Conversation
solidiquis
changed the title
solidiquis
requested changes
Apr 21, 2026
| let arrow_schema = parquet_to_arrow_schema( | ||
| metadata.file_metadata().schema_descr(), | ||
| metadata.file_metadata().key_value_metadata() | ||
| ).unwrap(); |
Collaborator
There was a problem hiding this comment.
Prefer anyhow context and early return with ? and avoid unwrap
| metadata.file_metadata().key_value_metadata() | ||
| ).unwrap(); | ||
|
|
||
| let mut time_column: Option<ParquetTimeColumn> = None; |
Collaborator
There was a problem hiding this comment.
Avoid explicitly typing your variables and allow Rust to do type inference everywhere it can.
| ).unwrap(); | ||
|
|
||
| let mut time_column: Option<ParquetTimeColumn> = None; | ||
| let mut data_columns: Vec<ParquetDataColumn> = Vec::new(); |
| let mut data_columns: Vec<ParquetDataColumn> = Vec::new(); | ||
|
|
||
| for field in arrow_schema.fields() { | ||
| // TODO: If no time_column handle that (invalid) |
solidiquis
requested changes
Apr 21, 2026
| use windows::{FooterMetadata, get_footer}; | ||
|
|
||
| pub mod flat_dataset; | ||
| pub mod detect; |
Collaborator
There was a problem hiding this comment.
module name needs work to better express intent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added detect.rs to add methods for parsing Parquet clientside instead of polling sift API