[MNT] move pre-commit config to `ruff` by arnavk23 · Pull Request #508 · sktime/skbase

arnavk23 · 2026-03-02T11:30:55Z

Reference Issues/PRs

Fixes #502

What does this implement/fix? Explain your changes.

This PR migrates the pre-commit configuration to use ruff as the unified tool for code formatting and linting, replacing the separate isort, black, and flake8 hooks. This aligns skbase with sktime and other GC.OS repositories for consistency and performance.

Does your contribution introduce a new dependency? If yes, which one?

Yes, ruff is added as a new dependency in the linters optional dependencies group in pyproject.toml. This is necessary to replace the functionality of isort, black, and flake8, providing a single, efficient tool for linting and formatting.

What should a reviewer concentrate their feedback on?

Correctness of the ruff configuration in pyproject.toml (rules, ignores, excludes).
Proper setup of pre-commit hooks in .pre-commit-config.yaml

Any other comments?

PR checklist

For all contributions

I've reviewed the project documentation on contributing
I've added myself to the list of contributors.
The PR title starts with either [ENH], [CI/CD], [MNT], [DOC], or [BUG] indicating whether
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.

For code contributions

Unit tests have been added covering code functionality
Appropriate docstrings have been added (see documentation standards)
New public functionality has been added to the API Reference

- Replace isort, black, flake8 with ruff in pre-commit hooks - Add ruff configuration to pyproject.toml - Update linters dependencies - Format and fix code with ruff

for more information, see https://pre-commit.ci

…2, SIM201, SIM103

for more information, see https://pre-commit.ci

…PIE810, RUF012, SIM102, SIM201, SIM103, SIM117, B018, D401, B904, RUF043 in some

arnavk23 · 2026-03-02T17:35:55Z

@fkiraly Please review this pr. Focus only on the precommit file as the rest changes are caused by moving to ruff.

codecov · 2026-03-02T17:39:25Z

Codecov Report

❌ Patch coverage is 79.74138% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.73%. Comparing base (306958d) to head (7928ffa).
⚠️ Report is 202 commits behind head on main.

Files with missing lines	Patch %	Lines
skbase/testing/test_all_objects.py	48.00%	13 Missing ⚠️
skbase/base/_meta.py	29.41%	12 Missing ⚠️
skbase/utils/deep_equals/_deep_equals.py	60.00%	12 Missing ⚠️
skbase/base/_base.py	86.36%	3 Missing ⚠️
skbase/testing/utils/_conditional_fixtures.py	66.66%	2 Missing ⚠️
skbase/utils/dependencies/_import.py	0.00%	2 Missing ⚠️
skbase/base/_clone_plugins.py	75.00%	1 Missing ⚠️
skbase/utils/dependencies/_dependencies.py	87.50%	1 Missing ⚠️
skbase/utils/git_diff.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   85.07%   83.73%   -1.35%     
==========================================
  Files          45       52       +7     
  Lines        3015     3854     +839     
==========================================
+ Hits         2565     3227     +662     
- Misses        450      627     +177

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arnavk23 · 2026-04-09T04:46:52Z

@fkiraly Franz I think this change can be added as it is completely done and whenever you push a pr here, I have to clear merge conflicts.

fkiraly · 2026-04-12T16:33:06Z

 [tool.bandit]
 exclude_dirs = ["*/tests/*", "*/testing/*"]
-
-[tool.setuptools]


why do we remove the setuptools config - seems like an accident

Thank you Franz for pointing that out. I have fixed it. You can review the pr again and hopefully merge this.

Also there are 3 more prs on this repo which you can check out.

fkiraly

Thanks! I think there is a minor issue here, see above. Please check.

fkiraly

@arnavk23, since you are using a lot of AI in your pull requests - and often not well checked - can you kindly explain explicitly how you applied the formatting to all files?

Further, how did you select the configuration? E.g., did you copy it from somewhere, or is the list of excepted codes coming out of an AI?

arnavk23 · 2026-04-19T19:56:48Z

@fkiraly I think there may be a misunderstanding. Most file changes came from Ruff auto-formatting during the migration. I followed the project’s existing Black/Flake8 behavior and put that into Ruff rather than introducing a new style. And the ignore are for warnings and error that may arise due to moving the previous files to ruff.

fkiraly · 2026-04-19T20:16:22Z

sure - can you please let me know how exactly you applied ruff?

Also please comment on the question where the excludes are coming from.

arnavk23 · 2026-04-19T20:20:04Z

sure - can you please let me know how exactly you applied ruff?

Also please comment on the question where the excludes are coming from.

@fkiraly, I applied Ruff by replacing the previous isort/black/flake8 pre-commit hooks with Ruff hooks and then running automated fixes. Most of the diff is formatting/lint cleanup rather than manual rewrites. For excludes/ignores, I did not copy a ready-made list from one source. I started from the project’s existing lint/format behavior, mapped that into Ruff and only added ignores when concrete migration warnings appeared.

arnavk23 · 2026-04-19T20:23:13Z

Also I think with the recent pushes, I am not able to resolve conflicts from my side so this might be hard to push afterall.

fkiraly · 2026-04-25T19:14:47Z

sure - can you please let me know how exactly you applied ruff? How did you run it?

Also please comment on the question where the excludes are coming from. Which "existing lint/format" behaviour are you referring to?

(repeated back/forth on replies without clear information indicates that there is an AI involved in the conversation)

arnavk23 · 2026-04-25T19:27:54Z

@fkiraly Franz this is getting a little out of hand now. Anything I do, you flag it as AI overuse. You have to understand if I am writing back to you, I am also trying to understand your message and your review as a contributor. On this pr, I just changed the pyproject as was written for black and flake8 and isort for ruff then run pre-commit and these were the changes made. I added warnings for errors that I didn't feel should be changed in the code for ruff to see. Everything is there in the file. In the comment above too I wrote the same thing. Explaining everything. I am not understanding why you always keep going about my prs in such a hostile manner. I am trying my best here to implement a new contribution. And for your knowledge, this pr has no AI used at all. All changes were made by me. Can you please discuss with me if you feel anything is wrong or incorrectly implemented, I would like for the two of us to have dialogue on things rather than you just coming and putting a bad review comment, not understanding my comment and going to other prs.

(Sorry for the harsh tone, but I genuinely feel this. Also the comments above the last comment which you called out specify rebase issue and the files that should be looked at, I wrote that with the ruff line. From my side, this is one of the prs, I felt was the most complete.)

Thank you for your time.

arnavk23 added 4 commits March 2, 2026 15:50

MNT: move pre-commit config to ruff

fed98a5

- Replace isort, black, flake8 with ruff in pre-commit hooks - Add ruff configuration to pyproject.toml - Update linters dependencies - Format and fix code with ruff

Add back UTF-8 encoding declarations and ignore UP009 rule

dcbb773

Add back UTF-8 encoding declarations to additional files

5823dda

Add UTF-8 coding declarations to all Python files changed in MNT commit

ac62a6d

arnavk23 force-pushed the fix/pre-commit-ruff branch from 40df124 to ac62a6d Compare March 2, 2026 11:42

arnavk23 and others added 4 commits March 2, 2026 17:13

Merge branch 'main' into fix/pre-commit-ruff

a9b8cec

[pre-commit.ci] auto fixes from pre-commit.com hooks

9ab9cf4

for more information, see https://pre-commit.ci

Fix ruff linting issues: UP035, RUF012, SIM118, RUF015, SIM108, SIM10…

018bf7e

…2, SIM201, SIM103

[pre-commit.ci] auto fixes from pre-commit.com hooks

36a3120

for more information, see https://pre-commit.ci

arnavk23 marked this pull request as draft March 2, 2026 12:00

arnavk23 added 2 commits March 2, 2026 23:02

Fix more ruff linting issues: SIM118, UP035, RUF013, SIM108, RUF005, …

8cbb9ec

…PIE810, RUF012, SIM102, SIM201, SIM103, SIM117, B018, D401, B904, RUF043 in some

Complete ruff migration: fix remaining issues and ignore E501

bccd909

arnavk23 marked this pull request as ready for review March 2, 2026 17:36

Merge branch 'main' into fix/pre-commit-ruff

97c0a76

fkiraly added the maintenance Continuous integration, unit testing & package distribution label Mar 5, 2026

fkiraly changed the title ~~MNT: move pre-commit config to ruff~~ [MNT] move pre-commit config to ruff Mar 5, 2026

arnavk23 added 2 commits March 6, 2026 08:59

Merge branch 'main' into fix/pre-commit-ruff

6c27583

Merge branch 'main' into fix/pre-commit-ruff

9d54831

fkiraly reviewed Apr 12, 2026

View reviewed changes

fkiraly requested changes Apr 12, 2026

View reviewed changes

arnavk23 added 2 commits April 13, 2026 00:33

Merge branch 'main' into fix/pre-commit-ruff

081dfcd

Update pyproject.toml

7928ffa

fkiraly requested changes Apr 19, 2026

View reviewed changes

fkiraly added the AI overuse suspected label Apr 25, 2026

Conversation

arnavk23 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

For code contributions

Uh oh!

arnavk23 commented Mar 2, 2026

Uh oh!

codecov Bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arnavk23 commented Apr 9, 2026

Uh oh!

fkiraly Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

arnavk23 Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fkiraly left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fkiraly left a comment

Choose a reason for hiding this comment

Uh oh!

arnavk23 commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fkiraly commented Apr 19, 2026

Uh oh!

arnavk23 commented Apr 19, 2026

Uh oh!

arnavk23 commented Apr 19, 2026

Uh oh!

fkiraly commented Apr 25, 2026

Uh oh!

arnavk23 commented Apr 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arnavk23 commented Mar 2, 2026 •

edited

Loading

codecov Bot commented Mar 2, 2026 •

edited

Loading

arnavk23 Apr 12, 2026 •

edited

Loading

fkiraly left a comment •

edited

Loading

arnavk23 commented Apr 19, 2026 •

edited

Loading