[SDK Configs] Rename split to definition to generalize the concept for Configs support#483
Merged
EmilianoSanchez merged 10 commits intosdk-configs-baselinefrom Apr 13, 2026
Conversation
… concept for Configs support
sanzmauro
reviewed
Mar 18, 2026
src/logger/messages/warn.ts
Outdated
| [c.WARN_CONVERTING, '%s: %s "%s" is not of type string, converting.'], | ||
| [c.WARN_TRIMMING, '%s: %s "%s" has extra whitespace, trimming.'], | ||
| [c.WARN_NOT_EXISTENT_SPLIT, '%s: feature flag "%s" does not exist in this environment. Please double check what feature flags exist in the Split user interface.'], | ||
| [c.WARN_NOT_EXISTENT_DEFINITION, '%s: definition "%s" does not exist in this environment. Please double check what definitions exist in the Split user interface.'], |
Contributor
There was a problem hiding this comment.
How are we going to identify which definition we're talking about? Whether it's a segment, flag, or config definition?
Contributor
Author
There was a problem hiding this comment.
Updated.
The first argument (%s) indicates the type: config, feature flag, etc, depending what is passed when called.
…-split-to-definition
…-split-to-definition
…-split-to-definition
Base automatically changed from
sdk-configs-handle-configs-dto
to
refactor-evaluator-to-support-no-target
April 8, 2026 18:31
Base automatically changed from
refactor-evaluator-to-support-no-target
to
sdk-configs-baseline
April 8, 2026 18:31
AI-Session-Id: b6e1bc93-ea86-4eef-b2d1-cfd87bd6cdcd AI-Tool: claude-code AI-Model: unknown
EmilianoSanchez
force-pushed
the
sdk-configs-rename-split-to-definition
branch
from
88f9476 to
1c77831
Compare
AI-Session-Id: 5273e4be-ae33-4f9e-9d3a-5bba29e624f2 AI-Tool: claude-code AI-Model: unknown
nmayorsplit
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript commons library
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes