Add SslOptions support to JedisClientConfiguration#3360
Open
gggeon96 wants to merge 2 commits intospring-projects:mainfrom
Open
Add SslOptions support to JedisClientConfiguration#3360gggeon96 wants to merge 2 commits intospring-projects:mainfrom
gggeon96 wants to merge 2 commits intospring-projects:mainfrom
Conversation
Expose Jedis's SslOptions on JedisClientConfiguration for consistency with the existing SSLSocketFactory, SSLParameters, and HostnameVerifier options. Wire it through to the Jedis JedisClientConfig.Builder in JedisConnectionFactory. See spring-projects#3355 Signed-off-by: Geonhyeon Kim <geon1120@gmail.com>
The setSslSocketFactory, setSslParameters and setHostnameVerifier setters have no invocations, leaving the corresponding fields permanently null. Remove the dead fields and setters; getters now return Optional.empty(). Closes spring-projects#3355 Signed-off-by: Geonhyeon Kim <geon1120@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
SslOptionssupport toJedisClientConfigurationfor consistency with the existingSSLSocketFactory,SSLParameters, andHostnameVerifieroptions, as discussed in #3355.The Mutable cleanup follows your direction: the
sslSocketFactory,sslParameters, andhostnameVerifierfields/setters had no invocations, so they are removed; the corresponding getters now returnOptional.empty().Open question
I used
@since 4.1as a placeholder — happy to retarget to whichever release line you prefer.Closes #3355