Clearer patterns#19
Open
aquila12 wants to merge 5 commits into
Open
Conversation
added 5 commits
November 29, 2023 16:28
Otherwise, "" doesn't match as it doesn't contain at least one non-backslash character before the closing quote.
Also permit new bundler
This makes any future work / debugging easier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the pattern matching into a field specification hash
This makes it easier to reuse patterns for fields and generally makes it easier to read and maintain the regex
NB this also contains the quote fix from my other PR