[PMREQ-810]: L2 support phase 1: Add Network CRD and RBAC for L2 VM mobility#4719
Draft
fasaxc wants to merge 3 commits intotigera:masterfrom
Draft
[PMREQ-810]: L2 support phase 1: Add Network CRD and RBAC for L2 VM mobility#4719fasaxc wants to merge 3 commits intotigera:masterfrom
fasaxc wants to merge 3 commits intotigera:masterfrom
Conversation
fasaxc
changed the title
Unblocks the calico-private wt-l2-prod-cni branch, which introduces
the new projectcalico.org/v3 Network resource for Layer 2 VM bridging.
Bundles the CRD into the enterprise imports tree and grants each
Calico component the minimum verbs it needs to operate against
Networks:
- calico-node (Felix): get/list/watch (bridge reconcile)
- calico-cni-plugin: get (resolve L2 attachments)
- calico-typha: get/list/watch (syncer fan-out)
- calico-apiserver: full CRUD (aggregated API backing)
- non-cluster-host Felix: get/list/watch (Felix watch layer
errors without RBAC,
even when the feature
is unused)
kube-controllers is intentionally out of scope: the finalizer
controller is Phase 2 per the PMREQ-810 design.
config/enterprise_versions.yml is temporarily pointed at the
wt-l2-prod-cni branch so "make fetch-enterprise-crds" pulls the new
CRD. Reset to "master" once wt-l2-prod-cni merges into
calico-private master.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Dropping the title bump keeps EnterpriseRelease as "master" and avoids a stale pkg/components/enterprise.go (which tripped CI dirty-check on the previous commit). Only libcalico-go.version needs to point at wt-l2-prod-cni for the CRD fetch. Also picks up crd.projectcalico.org_networks.yaml, which landed on the wt-l2-prod-cni branch after the first fetch. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Picks up the latest design iteration of the Network resource on the calico-private wt-l2-prod-cni branch: - Status subresource removed (deferred to Phase 2 with the kube-controllers Network controller). - "untagged" VLAN match replaced by per-trunk "nativeVLAN" semantics. - "broadcastMulticast" field dropped. No operator-side code or RBAC changes — Phase 1 RBAC is unchanged. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks the WIP calico-private branch
wt-l2-prod-cni(PMREQ-810 L2 VM mobility) by:projectcalico.org/v3.NetworkCRD into the enterprise CRD imports tree.Verb matrix added:
pkg/render/node.gopkg/render/node.gopkg/render/typha.gopkg/render/apiserver.gopkg/render/nonclusterhost/nonclusterhost.gocalico-kube-controllersis intentionally left out: the finalizer controller is Phase 2 per the design.Caveat — draft until calico-private lands
config/enterprise_versions.ymlis temporarily pointed at thewt-l2-prod-cnibranch somake fetch-enterprise-crdsfinds the new CRD. Reset tomasteroncewt-l2-prod-cnimerges intotigera/calico-private:master. Keeping this as a draft PR until then.Test plan
make format-checkmake static-checksmake test-crds(validates the bundled CRD serialises)make ut UT_DIR=./pkg/renderfocused on Node / Typha / API server / nonclusterhost suites — all passenterprise_versions.ymlback tomasteroncewt-l2-prod-cnimergesRelated
tigera/designs/2026/PMREQ-810-L2_VM_Mobility/wt-l2-prod-cni(already includes the operator-SAupdateRBAC for the CRD inmanifests/ocp/02-role-tigera-operator.yaml)