HERMETIC_CONFIG_EXTRA_ARGS contents added to generated proxy toolchain#42
Open
HERMETIC_CONFIG_EXTRA_ARGS contents added to generated proxy toolchain#42
Conversation
pysco68
force-pushed
the
feature/hfc_HERMETIC_CONFIG_EXTRA_ARGS_proxy_toolchain
branch
from
0ef8f1a to
a7194a7
Compare
pysco68
changed the title
pysco68
force-pushed
the
feature/hfc_HERMETIC_CONFIG_EXTRA_ARGS_proxy_toolchain
branch
from
a7194a7 to
6f80746
Compare
daminetreg
reviewed
Apr 28, 2026
daminetreg
requested changes
Apr 28, 2026
Contributor
daminetreg
left a comment
daminetreg
left a comment
There was a problem hiding this comment.
Thanks for the abi-hash fix + the docs.
I think however that the libev examples with --disable-static / --enable-shared is a bad example because this is supported already through our support of CMake BUILD_SHARED_LIBS https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html
Why not removing the libev example and just adding the extra ARG example in the existing openssl example ?
…ed to generated proxy toolchain CHANGELOG: - Ensuring changes to HERMETIC_CONFIG_EXTRA_ARGS are appended to the generated proxy toolchain - added example libev using this feature - updated documentation Change-Id: Ice7231a7fd956608ce2404c74878c6b6edec7131
pysco68
force-pushed
the
feature/hfc_HERMETIC_CONFIG_EXTRA_ARGS_proxy_toolchain
branch
from
6f80746 to
473c905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG: