Add github.com/cockroachdb/errors to hooks as alternative errors package#413
Open
ian-oneleet wants to merge 1 commit intouber-go:mainfrom
Open
Add github.com/cockroachdb/errors to hooks as alternative errors package#413ian-oneleet wants to merge 1 commit intouber-go:mainfrom
github.com/cockroachdb/errors to hooks as alternative errors package#413ian-oneleet wants to merge 1 commit intouber-go:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/cockroachdb/errors is a popular alternative to the stdlib
errorspackage. It provides alternative versions oferrors.New,fmt.Errorf(which it callserrors.Newf), anderrors.Join, among other functions.Nilaway currently flags more false positives for codebases that use
cockroachdb/errorsinstead of stdliberrors, because the built-in special cases for stdliberrorsdon't carry over tocockroachdb/errors. This PR duplicates the special cases inhook/assume_return.goandhook/replace_conditional.goso that they work withcockroachdb/errors.Code was produced with LLM assistance (Claude).