Open
Conversation
Expand INI values known to be paths during initial loading. This prevents having to guess where paths came from in later processing. Signed-off-by: Randolph Sapp <rs@ti.com>
Instead of appending configurations directly we should use the common shadow loading functions we've defined. This allows paths to be expanded properly ahead of time, and still use the shadow processing mechanisms other mechanisms expect. This also enforces the load order through the list of sources built and passed to processSources. Signed-off-by: Randolph Sapp <rs@ti.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(loadINI): use standard shadow loading
Instead of appending configurations directly we should use the common shadow
loading functions we've defined. This allows paths to be expanded properly
ahead of time, and still use the shadow processing mechanisms other mechanisms
expect.
This also enforces the load order through the list of sources built and passed
to processSources.
Signed-off-by: Randolph Sapp rs@ti.com
fix(ini): expand paths during load
Expand INI values known to be paths during initial loading. This prevents
having to guess where paths came from in later processing.
Signed-off-by: Randolph Sapp rs@ti.com
Fixes: #1095