Refactor eth tx nonce subsystem and enforce linear growth #1617
Open
libotony wants to merge 9 commits into
Open
Refactor eth tx nonce subsystem and enforce linear growth #1617libotony wants to merge 9 commits into
libotony wants to merge 9 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
e364bad to
b86998f
Compare
moglu2017
approved these changes
May 11, 2026
otherview
reviewed
May 11, 2026
paologalligit
approved these changes
May 14, 2026
otherview
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on
eth-equivalence(which already has on-state nonce wiring from #1616 with two changes:Refactor
state.Account.Nonce:[]uint64withrlp:"tail"→uint64withrlp:"optional"(same byte-encoding, simpler in-memory shape).runtime/statedb: struct-with-txType-field →StateDBinterface with V1 (no-op SetNonce) and V2 (write-through SetNonce). Dispatched bytxCtx.TypeinRuntime.newStateDB.PrepareTransaction(post-clause) toPrepareClause(pre-evm.Call). Mirrors Ethereum's nonce-write-outside-EVM-snapshot pattern; on VMErr, eth tx skips the outerstate.RevertToso the increment survives.Add
<reject,>queue/defer/invalid,==admit.Checklist: