Skip to content

chore: post-v0.4.36 cleanup (delete setup.py, fix release defaults, fix README)#233

Merged
vietanhdev merged 1 commit intomainfrom
cleanup/post-v0.4.36
Apr 25, 2026
Merged

chore: post-v0.4.36 cleanup (delete setup.py, fix release defaults, fix README)#233
vietanhdev merged 1 commit intomainfrom
cleanup/post-v0.4.36

Conversation

@vietanhdev
Copy link
Copy Markdown
Owner

Follow-up cleanup after v0.4.36 lands the CI gate and GPU publish fix. Pure cleanup — net -45 lines, no functional behaviour change for end-users.

Changes

  • Delete `setup.py`. The shim that used to switch the package name to `anylabeling-gpu` is silently rejected by PEP 621 — `[project].name` in `pyproject.toml` is static. After ci: gate publish on cross-platform tests; fix GPU + resource scripts (re-target main) #232 made the GPU workflow `sed`-rewrite `pyproject.toml` directly, this file is dead code. Verified: `python -m build` produces identical metadata before and after deletion.
  • `release.yml` defaults: `draft: false`, `prerelease: false`, `make_latest: 'true'`. Today every tag landed as a draft prerelease and needed a manual `gh release edit` to promote (we did this for v0.4.36). After this PR, tags publish straight away.
  • `README.md`: bump "Python 3.10+" to "Python 3.11+" to match `requires-python` in `pyproject.toml`. `pip` refuses to install on 3.10 today, so the README was misleading.
  • `CLAUDE.md`: the resource-script section still described the broken pre-ci: gate publish on cross-platform tests; fix GPU + resource scripts (re-target main) #232 state (`pyrcc5`/`pyrcc6` calls). Replace with the post-fix story (`pyside6-rcc` + `pyside6-lrelease` with PyQt6 import rewrite).

Verified

  • Local CPU wheel build without `setup.py` produces identical `Name`, `Version`, and `Requires-Dist` metadata.
  • The 9-cell test matrix on this PR will exercise both the no-setup-py install path and the unchanged unit suite.

- Delete setup.py. The shim that used to switch the package name to
  anylabeling-gpu is silently rejected by PEP 621 (pyproject.toml's
  [project].name is static). After the GPU publish workflow started
  sed-rewriting pyproject.toml directly in #232, the shim is dead
  code. Verified: python -m build produces identical metadata before
  and after deletion. setuptools.build_meta reads pyproject.toml
  without needing setup.py.

- README: bump 'Python 3.10+' to 'Python 3.11+' to match
  requires-python in pyproject.toml. pip refuses to install on 3.10
  today, so the README was actively misleading.

- release.yml: flip the action-gh-release defaults so a tag push
  produces a published, non-prerelease, latest-marked release on its
  own. Previously every tag landed as a draft prerelease and needed a
  manual gh release edit (we did this for v0.4.36 today).

- CLAUDE.md: the resource-script section described the broken
  pre-#232 state (pyrcc5/pyrcc6 calls). Replace with the post-fix
  story (pyside6-rcc + pyside6-lrelease with PyQt6 import rewrite).
@vietanhdev vietanhdev merged commit 5c15bbf into main Apr 25, 2026
9 checks passed
@vietanhdev vietanhdev deleted the cleanup/post-v0.4.36 branch April 25, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant