chore: post-v0.4.36 cleanup (delete setup.py, fix release defaults, fix README)#233
Merged
vietanhdev merged 1 commit intomainfrom Apr 25, 2026
Merged
chore: post-v0.4.36 cleanup (delete setup.py, fix release defaults, fix README)#233vietanhdev merged 1 commit intomainfrom
vietanhdev merged 1 commit intomainfrom
Conversation
- Delete setup.py. The shim that used to switch the package name to anylabeling-gpu is silently rejected by PEP 621 (pyproject.toml's [project].name is static). After the GPU publish workflow started sed-rewriting pyproject.toml directly in #232, the shim is dead code. Verified: python -m build produces identical metadata before and after deletion. setuptools.build_meta reads pyproject.toml without needing setup.py. - README: bump 'Python 3.10+' to 'Python 3.11+' to match requires-python in pyproject.toml. pip refuses to install on 3.10 today, so the README was actively misleading. - release.yml: flip the action-gh-release defaults so a tag push produces a published, non-prerelease, latest-marked release on its own. Previously every tag landed as a draft prerelease and needed a manual gh release edit (we did this for v0.4.36 today). - CLAUDE.md: the resource-script section described the broken pre-#232 state (pyrcc5/pyrcc6 calls). Replace with the post-fix story (pyside6-rcc + pyside6-lrelease with PyQt6 import rewrite).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup after v0.4.36 lands the CI gate and GPU publish fix. Pure cleanup — net -45 lines, no functional behaviour change for end-users.
Changes
Verified