fix(makefile): remove stale clean target cleanup#330
fix(makefile): remove stale clean target cleanup#330mrinalchaturvedi27 wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request simplifies the clean target in the Makefile by removing specific binary deletions. Review feedback suggests adding a help description to the target for consistency and expanding the cleanup command to include build artifacts from the Python SDK and CLI directories.
There was a problem hiding this comment.
Pull request overview
Removes a stale root-level binary cleanup step from make clean, aligning the clean target with the actual build output location (bin/) used by AgentCube’s Makefile-based build workflow.
Changes:
- Drop
rm -f workloadmanager agentd agentcube-routerfrom thecleantarget since builds already output tobin/. - Keep
make cleanfocused on removingbin/, which contains the built artifacts produced bygo build -o bin/....
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 47.57% 49.12% +1.55%
==========================================
Files 30 30
Lines 2819 2858 +39
==========================================
+ Hits 1341 1404 +63
+ Misses 1338 1301 -37
- Partials 140 153 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mrinal Chaturvedi <mrinal.chaturvedi27@gmail.com>
|
Hi @hzxuzhonghu @YaoZengzeng quick ping for this PR :) |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This updates
make cleanso it removes the Go binary output and Python package build artifacts. It also adds the clean target tomake help.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
No generated files changed. I checked the target with
make -n clean,make clean, andmake help.Does this PR introduce a user-facing change?:
What I fixed
I fixed
make clean.The Makefile builds Go binaries inside
bin/, and the Python SDK and CLI build targets write packages tosdk-python/dist/andcmd/cli/dist/. The old clean target removed onlybin/.How I checked it
I checked the Makefile build targets and confirmed the Go and Python build output paths.
What I changed
I removed the unused root-level
rm -fline, added a help description forclean, and included the Python packagedist/folders in cleanup.Why this is okay
This is a small cleanup fix. The target now matches the actual build outputs and appears in
make help.Validation
make -n clean- Passed.make clean- Passed.make help- Passed;cleanis listed with its description.Signed-off-bylines.