Cloud status badge for remote child pills in orchestration pill bar#10696
Merged
Conversation
Routes the pill avatar+status through the shared icon-with-status helper so remote children render with a cloud-shaped status overlay and local children keep the existing circle badge. Adds a CustomAvatar variant to the helper so callers with bespoke avatars (deterministic-color disc + initial letter) can reuse its overlay treatment. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR routes orchestration child pill avatars through the shared icon-with-status helper and adds a custom avatar variant so remote children can display cloud-shaped status badges.
Concerns
- The cloud badge loses its silhouette on selected remote child pills because the helper's cloud fill matches the selected pill background.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
- Fold CIRCLE_RATIO rationale into the existing ratios comment block - Clarify orchestrator's is_remote_child comment (unused, not 'always local') Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
cephalonaut
pushed a commit
that referenced
this pull request
May 12, 2026
dagmfactory
pushed a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://warpdev.slack.com/archives/C09769R5GBT/p1778454446358659?thread_ts=1778358236.922579&cid=C09769R5GBT for context
Fixes https://linear.app/warpdotdev/issue/QUALITY-679/add-cloud-indicator-to-pill-status-badge
zoomed out:
Description
Differentiates remote (cloud) child agents from local ones in the orchestration pill bar by rendering their status badge as a cloud silhouette (with the status icon inside) instead of the circular badge used for local children.
Routes the pill avatar through the shared icon-with-status helper that's already used by vertical tabs, the conversation list, agent management, etc. — adds a small
CustomAvatarvariant to the helper so callers with bespoke avatars (the pill bar uses a deterministic-color disc + initial letter) can reuse the existing circle/cloud overlay treatment. Local children keep the existing circle-badge look unchanged; only the cloud variant is new.Picks up Harry's
StatusColorStyle::Cloudwork for free (status icons inside the cloud useansi_bg_*tints so they stay readable on the white cloud fill).