Billing & Usage Page Blank Canvas#10701
Conversation
…-page-v2 # Conflicts: # crates/warp_features/src/lib.rs
tylerlam-warp
changed the title
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a feature-flagged blank Billing & Usage V2 settings page and routes the settings view to either the new blank page or the existing page based on BillingAndUsagePageV2.
Concerns
- The V2 page no longer preserves the existing Billing & Usage logged-out/anonymous visibility behavior.
- The V2 page reports a positive search match for every query, so unrelated settings searches can keep or select the blank Billing & Usage page.
- This is a user-visible settings change, but the PR includes only textual manual testing. Manual testing is required for changes that can be manually tested. Please include screenshots or a screen recording that show the flag-on blank canvas and flag-off fallback working end to end, or justify why visual evidence is not possible.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
IsaiahWitzke
left a comment
IsaiahWitzke
left a comment
There was a problem hiding this comment.
stamped... but those oz-for-oss comments seem reasonable
|
will fix those |
## Description Creates a blank canvas for the new Billing & Usage page for both me and Jeff to work on tomorrow. ## Testing Just confirmed: - If the billing & usage page V2 feature flag is on, I see a blank age (canvas) in the settings page - If the billing & usage page V2 feature flag is off, I see the old billing and usage page - [x] I have manually tested my changes locally with `./script/run`
2 participants
Description
Creates a blank canvas for the new Billing & Usage page for both me and Jeff to work on tomorrow.
Testing
Just confirmed:
If the billing & usage page V2 feature flag is on, I see a blank age (canvas) in the settings page
If the billing & usage page V2 feature flag is off, I see the old billing and usage page
I have manually tested my changes locally with
./script/run