Add auth tests to verify cases of invalid/unknowen return value#925
Open
yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Add auth tests to verify cases of invalid/unknowen return value#925yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression tests to ensure server-side userAuth callbacks returning unknown/out-of-enum values do not accidentally grant authentication (issue 2486).
Changes:
- Adds a password-auth test where the server callback returns an invalid value (-999) and verifies auth fails.
- Adds a keyboard-interactive test where the server callback returns an invalid value (-999) during the response-validation step and verifies auth fails.
- Registers the new tests in
wolfSSH_AuthTest().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests to exercises the default branch In both DoUserAuthRequestPassword()and DoUserAuthInfoResponse().
Server registers custom userAuthCb that returns an invalid/unknown value (e.g., -999). Then, it verifies that authentication fails.