Have Buffer class implement the Seekable interface#361
Open
thekid wants to merge 8 commits intoxp-framework:mainfrom
Open
Have Buffer class implement the Seekable interface#361thekid wants to merge 8 commits intoxp-framework:mainfrom
thekid wants to merge 8 commits intoxp-framework:mainfrom
Conversation
If an `io.TempFile` instance is passed, its destructor may have deleted the file itself
Visible instead of implicit operator precedence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the
io.streams.Bufferclass useable for more I/O purposes. The file pointer is advanced for read and write operations, just like insideio.Fileinstances!TODO
io.streams.Seekable.io.Fileinstances to constructor