Fix Conan cache restore isolation#1610
Merged
sre-ci-robot merged 1 commit intozilliztech:mainfrom Apr 30, 2026
Merged
Conversation
Clear Conan package storage before restoring actions/cache so self-hosted runner leftovers cannot collide with restored cache metadata. Drop broad Conan restore-key fallback so dependency changes do not borrow stale caches from main or older PR keys. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
|
@jamesgao-jpg 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Collaborator
Collaborator
|
/lgtm |
Collaborator
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, foxspy, jamesgao-jpg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR makes the GitHub Actions Conan cache restore safer on self-hosted runners.
It was prompted by PR #1609, whose Unit Test run restored a stale
mainConan cache via the broadrestore-keysprefix and then failed with a Conan package directory collision.Changes:
restore-keysso a changedconanfile.pyno longer falls back to an older Conan cache~/.conan2/pbefore restoring the Conan cache so persistent runner leftovers cannot collide with restored Conan metadataVerification
Ran locally:
git diff --checkrestore-keyspython3YAML parse of.github/actions/cache-restore/action.yamlNote: full validation requires a GitHub Actions run on the self-hosted runner.