Skip to content

Drop BQu Mixin#363

Merged
tier940 merged 1 commit intomasterfrom
tier-drop-bqu-mixin
Apr 19, 2026
Merged

Drop BQu Mixin#363
tier940 merged 1 commit intomasterfrom
tier-drop-bqu-mixin

Conversation

@tier940
Copy link
Copy Markdown
Member

@tier940 tier940 commented Apr 19, 2026

No description provided.

@tier940 tier940 self-assigned this Apr 19, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the project's mixin architecture by removing the Better Questing integration. Additionally, it updates various debug-related dependencies to their latest versions and includes a targeted fix to resolve potential boot errors related to EnderCore.

Highlights

  • Removal of Better Questing Mixin: Removed the 'GuiHomeUpdateMixin' and its associated configuration, effectively dropping the Better Questing mixin support.
  • Dependency Updates: Updated several debug dependencies including GTWoodProcessing, ImplosionNoBomb, and Avaritia to newer versions.
  • Build Configuration Changes: Cleaned up buildscript properties and repository configurations, and added a specific boot error fix for EnderCore.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tier940 tier940 merged commit fa8daf5 into master Apr 19, 2026
2 checks passed
@tier940 tier940 deleted the tier-drop-bqu-mixin branch April 19, 2026 11:08
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストでは、GTWoodProcessing、ImplosionNoBomb、Avaritiaの依存関係の更新、およびBetter Questing Unofficial (BQu) と関連するMixinの削除が行われました。また、起動エラー修正のためにEnderCoreのローカルJARが追加されています。フィードバックとして、開発環境での難読化解除を適切に行うための rfg.deobf() の適用漏れの修正と、EnderCoreの重複定義の解消が提案されています。

Comment thread dependencies.gradle
// Debug GTWoodProcessing: 1.2.5
if (project.debug_all.toBoolean() || project.debug_gtwp.toBoolean()) {
runtimeOnly "curse.maven:gtwoodprocessing-1093753:6334967"
runtimeOnly "curse.maven:gtwoodprocessing-1093753:7691291"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

runtimeOnly の指定に rfg.deobf() が適用されていません。開発環境では難読化解除されたコードが使用されるため、この指定がないと実行時にクラスやメソッドが見つからずエラーになる可能性があります。他の依存関係との一貫性を保つためにも、rfg.deobf() を使用することを推奨します。

        runtimeOnly rfg.deobf("curse.maven:gtwoodprocessing-1093753:7691291")

Comment thread dependencies.gradle
compileOnly rfg.deobf("curse.maven:implosionnobomb-1094386:7945769")
if (project.debug_all.toBoolean() || project.debug_inb.toBoolean()) {
runtimeOnly "curse.maven:implosionnobomb-1094386:5731331"
runtimeOnly "curse.maven:implosionnobomb-1094386:7945769"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

71 行目の compileOnly では rfg.deobf() が使用されていますが、こちらの runtimeOnly では使用されていません。コンパイル時と実行時で難読化の状態が異なると、開発環境での実行時に NoSuchMethodError などのエラーが発生する原因となります。

        runtimeOnly rfg.deobf("curse.maven:implosionnobomb-1094386:7945769")

Comment thread dependencies.gradle

// Boot error fix
if (project.debug_all.toBoolean() || project.debug_eio.toBoolean()) {
runtimeOnly files("libs/EnderCore-1.12.2-0.5.78-core.jar")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

EnderCore の依存関係が 111 行目と 151 行目で重複して定義されています。どちらも runtimeOnly かつ同じバージョン(0.5.78)を指しているため、クラスパスの競合を引き起こす可能性があります。151 行目のローカルファイルが起動エラーの修正として必要な場合は、111 行目の定義を削除するかコメントアウトすることを検討してください。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant