Skip to content

Drop BQu Mixin #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tier940 merged 1 commit into from
Apr 19, 2026
Merged

Drop BQu Mixin #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion buildscript.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ debug_deda = false
debug_avaritia = false
debug_gtfo = false
debug_jer = false
debug_bqu = false

# Select a username for testing your mod with breakpoints. You may leave this empty for a random username each time you
# restart Minecraft in development. Choose this dependent on your mod:
Expand Down
26 changes: 13 additions & 13 deletions dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ dependencies {
compileOnly "curse.maven:ctm-267602:2915363" // CTM 1.0.2.31
runtimeOnly "com.cleanroommc:modularui:2.4.3" // MUI 2.4.3

// Debug GTWoodProcessing: 1.2.4
// Debug GTWoodProcessing: 1.2.5
if (project.debug_all.toBoolean() || project.debug_gtwp.toBoolean()) {
runtimeOnly "curse.maven:gtwoodprocessing-1093753:6334967"
runtimeOnly "curse.maven:gtwoodprocessing-1093753:7691291"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

runtimeOnly の指定に rfg.deobf() が適用されていません。開発環境では難読化解除されたコードが使用されるため、この指定がないと実行時にクラスやメソッドが見つからずエラーになる可能性があります。他の依存関係との一貫性を保つためにも、rfg.deobf() を使用することを推奨します。

        runtimeOnly rfg.deobf("curse.maven:gtwoodprocessing-1093753:7691291")

}

// Debug ImplosionNoBomb: 1.1.0
compileOnly rfg.deobf("curse.maven:implosionnobomb-1094386:5731331")
// Debug ImplosionNoBomb: 1.1.1
compileOnly rfg.deobf("curse.maven:implosionnobomb-1094386:7945769")
if (project.debug_all.toBoolean() || project.debug_inb.toBoolean()) {
runtimeOnly "curse.maven:implosionnobomb-1094386:5731331"
runtimeOnly "curse.maven:implosionnobomb-1094386:7945769"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

71 行目の compileOnly では rfg.deobf() が使用されていますが、こちらの runtimeOnly では使用されていません。コンパイル時と実行時で難読化の状態が異なると、開発環境での実行時に NoSuchMethodError などのエラーが発生する原因となります。

        runtimeOnly rfg.deobf("curse.maven:implosionnobomb-1094386:7945769")

}

// Debug ExtraCells2 Additions
Expand Down Expand Up @@ -130,15 +130,10 @@ dependencies {
runtimeOnly rfg.deobf("curse.maven:draconicadditions-314515:3514704")
}

// Debug BQu: 4.2.7
compileOnly rfg.deobf("curse.maven:better-questing-unofficial-629629:7421294")
if (project.debug_all.toBoolean() || project.debug_bqu.toBoolean()) {
runtimeOnly rfg.deobf("curse.maven:better-questing-unofficial-629629:7421294")
}

// Debug Avaritia: 3.3.0.47-hotfix1
// Avaritia: 3.3.0.48-hotfix7
compileOnly rfg.deobf("curse.maven:avaritia-1-1x-unofficial-1165010:7939693")
if (project.debug_all.toBoolean() || project.debug_avaritia.toBoolean()) {
runtimeOnly rfg.deobf("curse.maven:avaritia-1-1x-unofficial-1165010:7186329")
runtimeOnly rfg.deobf("curse.maven:avaritia-1-1x-unofficial-1165010:7939693")
}

// Debug GTFO: 1.12.5
Expand All @@ -150,4 +145,9 @@ dependencies {
if (project.debug_all.toBoolean() || project.debug_jer.toBoolean()) {
runtimeOnly "curse.maven:just-enough-resources-jer-240630:2728585"
}

// Boot error fix
if (project.debug_all.toBoolean() || project.debug_eio.toBoolean()) {
runtimeOnly files("libs/EnderCore-1.12.2-0.5.78-core.jar")
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

EnderCore の依存関係が 111 行目と 151 行目で重複して定義されています。どちらも runtimeOnly かつ同じバージョン（0.5.78）を指しているため、クラスパスの競合を引き起こす可能性があります。151 行目のローカルファイルが起動エラーの修正として必要な場合は、111 行目の定義を削除するかコメントアウトすることを検討してください。

}
}
3 changes: 0 additions & 3 deletions repositories.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@ repositories {
name 'GTCEu Maven'
url 'https://maven.gtceu.com'
}
flatDir {
dirs 'libs'
}
}
1 change: 0 additions & 1 deletion src/main/java/com/github/gtexpert/core/mixins/GTEMixinLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
public class GTEMixinLoader implements ILateMixinLoader {

public static final Map<String, Boolean> modMixinsConfig = new ImmutableMap.Builder<String, Boolean>()
.put(Mods.Names.BETTER_QUESTING, true)
.put(Mods.Names.DRACONIC_EVOLUTION, true)
.put(Mods.Names.DRACONIC_ADDITIONS, true)
.put(Mods.Names.GREGTECH, true)
Expand Down
57 changes: 0 additions & 57 deletions src/main/java/com/github/gtexpert/core/mixins/betterquesting/GuiHomeUpdateMixin.java
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/main/resources/mixins.gtexpert.betterquesting.json
View file
Open in desktop

This file was deleted.