Conversation
Contributor
|
Hi @kittiu, |
…ing units access Co-authored-by: Copilot <copilot@github.com>
086d262 to
96c59a3
Compare
HekkiMelody
suggested changes
Apr 27, 2026
Contributor
HekkiMelody
left a comment
There was a problem hiding this comment.
- it's usually best to avoid using
replaceunless absolutely necessary. In this case, it'd be more compatible to simply operate on thedomainattribute, I think. All other field customizations are lost otherwise. - The issue being fixed here is that a user with "Manage all OUs" doesn't seems to be able to select any OUs.
- Checking the field
user_idsto limit the visible operating units is obsolete and unnecessary because the available operating units are already filtered by record rules automatically based on what the user has available. Additionally people who have all operating units available don't appear in theuser_idsfield, which is what causes the underlying issue. (This was already raised in this PR.) So I think these changes shouldn't go here, but rather instock_operating_unit. See this PR for an example of the same fix. Most modules inoperating-unitcould potentially benefit from the same fix.
Contributor
|
Can you check if this PR fixes the issue? |
Contributor
Author
Thanks for the review, you has been faster than me to apply changes. Closing this one in favor of #850 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.