[14.0][FIX] stock_operating_unit: allow manager to select OUs#850
Merged
OCA-git-bot merged 1 commit intoOCA:14.0from Apr 28, 2026
Merged
[14.0][FIX] stock_operating_unit: allow manager to select OUs#850OCA-git-bot merged 1 commit intoOCA:14.0from
OCA-git-bot merged 1 commit intoOCA:14.0from
Conversation
Contributor
Author
|
Pre-commit failure is fixed by: #851 |
Checking the field `user_ids` of `operating.unit` to set a domain is both unnecessary (record rules already filter the correct records) and wrong/obsolete because users who are managers of all OUs don'the appear in the `user_ids` field.
fc725ba to
d16afcd
Compare
GSLabIt
approved these changes
Apr 27, 2026
Contributor
|
@AaronHForgeFlow could you take a look? thanks! |
AaronHForgeFlow
approved these changes
Apr 28, 2026
Contributor
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
this is already in versions > 14 (a2c7871) so no need to FW
Contributor
|
/ocabot merge minor |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at e1c3082. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the field
user_idsofoperating.unitto set a domain is both unnecessary (record rules already filter the correct records) and wrong/obsolete because users who are managers of all OUs don'the appear in theuser_idsfield.Alternative to #849