Skip to content

[14.0][FIX] stock_operating_unit: allow manager to select OUs#850

Merged
OCA-git-bot merged 1 commit intoOCA:14.0from
PyTech-SRL:14.0-ou-access-all
Apr 28, 2026
Merged

[14.0][FIX] stock_operating_unit: allow manager to select OUs#850
OCA-git-bot merged 1 commit intoOCA:14.0from
PyTech-SRL:14.0-ou-access-all

Conversation

@HekkiMelody
Copy link
Copy Markdown
Contributor

@HekkiMelody HekkiMelody commented Apr 27, 2026

Checking the field user_ids of operating.unit to set a domain is both unnecessary (record rules already filter the correct records) and wrong/obsolete because users who are managers of all OUs don'the appear in the user_ids field.

Alternative to #849

@OCA-git-bot OCA-git-bot added series:14.0 mod:stock_operating_unit Module stock_operating_unit labels Apr 27, 2026
@HekkiMelody HekkiMelody changed the title [FIX] stock_operating_unit: allow manager to select OUs [14.0][FIX] stock_operating_unit: allow manager to select OUs Apr 27, 2026
@HekkiMelody
Copy link
Copy Markdown
Contributor Author

Pre-commit failure is fixed by: #851

Copy link
Copy Markdown
Contributor

@GSLabIt GSLabIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checking the field `user_ids` of `operating.unit` to set a domain is
both unnecessary (record rules already filter the correct records) and
wrong/obsolete because users who are managers of all OUs don'the
appear in the `user_ids` field.
Copy link
Copy Markdown
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@francesco-ooops
Copy link
Copy Markdown
Contributor

@AaronHForgeFlow could you take a look? thanks!

Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already in versions > 14 (a2c7871) so no need to FW

@AaronHForgeFlow
Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-850-by-AaronHForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e5842a4 into OCA:14.0 Apr 28, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at e1c3082. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants