Skip to content

PIR: Add new email flexibility action models#8232

Open
landomen wants to merge 3 commits intodevelopfrom
feature/domen/pir-email-flexibility-models
Open

PIR: Add new email flexibility action models#8232
landomen wants to merge 3 commits intodevelopfrom
feature/domen/pir-email-flexibility-models

Conversation

@landomen
Copy link
Copy Markdown
Contributor

@landomen landomen commented Apr 9, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1213886961787937?focus=true

Description

Adds new models for two new broker actions needed to support email flexibility.

Steps to test this PR

No QA needed, will be testable on later branches

UI changes

No UI changes


Note

Medium Risk
Adds new PIR broker action types to the core polymorphic JSON model/adapter wiring; if the actionType strings or fields don’t match the JS payloads, script action parsing/execution could fail at runtime.

Overview
Adds two new broker action models, BrokerAction.GenerateEmail and BrokerAction.GetEmailData (with pollingTime/extract), and extends asActionType() to emit the new actionType strings.

Updates PIR’s Moshi PolymorphicJsonAdapterFactory configuration to deserialize these new actionTypes, and extends the FakePirMessagingInterface test fake to return success responses for them during integration tests.

Reviewed by Cursor Bugbot for commit c34b397. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

landomen commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f3281cc. Configure here.

Comment thread pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/scripts/models/BrokerAction.kt Outdated
@landomen landomen force-pushed the feature/domen/pir-email-flexibility-models branch from c34b397 to 8b6b0dd Compare April 29, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants