PIR: Add broker step action handler logic by landomen · Pull Request #8282 · duckduckgo/Android

landomen · 2026-04-15T12:11:36Z

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1213886961787939?focus=true

Description

Adds logic for the new GenerateEmail action.

Steps to test this PR

Will be testable later on the top stacked PR

UI changes

No UI changes

Note

Medium Risk
Touches CI automation and secret-handling paths in GitHub Actions and adds new telemetry definitions, which can impact workflow behavior and metrics if misconfigured; app/runtime code changes are mostly additive UI components.

Overview
Agentic workflow automation: Adds a new action-agentic-maintenance-pr workflow that, when a PR is opened or labeled agentic-maintenance, extracts an Asana task from the PR body and moves it to In Review. The Android maintenance worker workflow is extended to auto-label created PRs, allow app.asana.com, and spin up a new MCP Scripts HTTP server for read-only Asana access (plus additional secret redaction/artifacts). nightly-orchestrator.yml now collects Asana task IDs from commits since the tagged LGC and moves them into a release-candidate section.

Android UI / design system: Adds new Compose components DaxCard, DaxSurface, and DaxSwitch (with theme-driven colors) and updates the internal component gallery to render Compose switch/card variants using the current theme. The onboarding bubble card view is enhanced to resolve onboarding theme attrs safely and to optionally hide/show the arrow while managing bottom margins.

Tests & telemetry definitions: Maestro flows are refactored to reuse new shared dismiss_fire_dialog/confirm_fire_dialog subflows and handle an optional return-hatch after restart. Pixel definitions are updated with new pixels/params (e.g., error/Asana-related, Duck.ai native storage/migration, NTP-after-idle, error page pixels) and some pixel metadata/parameters are expanded.

^{Reviewed by Cursor Bugbot for commit feb3698. Bugbot is set up for automated code reviews on this repo. Configure here.}

landomen · 2026-04-15T12:11:53Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

PIR: Add handling of GenerateEmail action #8294
PIR: Add broker step action handler logic #8282 👈 (View in Graphite)
PIR: Add state engine models for email flexibility #8233
PIR: Add new email flexibility action models #8232
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

landomen · 2026-04-15T12:15:25Z

+                            stageStartMs = currentTimeProvider.currentTimeMillis(),
+                        ),
+                    ),
+                    sideEffect = GetEmailForProfile(


Note: failure is handled in the existing PirActionsRunner.handleGetEmail, which calls PirActionsRunner.onError(EmailError) which dispatches ErrorReceived which ultimately dispatches

Event.BrokerActionFailed( error = result.error, allowRetry = false, )

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 57b9781. Configure here.}

daxmobile

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

actionlint

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:18:53: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 638 in feb3698

run: |

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 718 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/clean_git_credentials.sh

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 838 in feb3698

run: |

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 859 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/append_agent_step_summary.sh

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 1113 in feb3698

    
           run: bash ${RUNNER_TEMP}/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-firewall/agent:0.25.4 ghcr.io/github/gh-aw-firewall/api-proxy:0.25.4 ghcr.io/github/gh-aw-firewall/squid:0.25.4

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 1172 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/install_awf_binary.sh v0.25.4

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:40: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/nightly-orchestrator.yml

Line 21 in feb3698

run: |

daxmobile · 2026-04-29T05:11:55Z

          GH_AW_GITHUB_RUN_ID: ${{ github.run_id }}
          GH_AW_GITHUB_WORKSPACE: ${{ github.workspace }}
        # poutine:ignore untrusted_checkout_exec
        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:55Z

+          {"create_pull_request":{"base_branch":"develop","draft":true,"github-token":"${{ secrets.GT_DAXMOBILE }}","labels":["agentic-maintenance"],"max":1,"max_patch_size":1024,"protected_files":["package.json","bun.lockb","bunfig.toml","deno.json","deno.jsonc","deno.lock","global.json","NuGet.Config","Directory.Packages.props","mix.exs","mix.lock","go.mod","go.sum","stack.yaml","stack.yaml.lock","pom.xml","build.gradle","build.gradle.kts","settings.gradle","settings.gradle.kts","gradle.properties","package-lock.json","yarn.lock","pnpm-lock.yaml","npm-shrinkwrap.json","requirements.txt","Pipfile","Pipfile.lock","pyproject.toml","setup.py","setup.cfg","Gemfile","Gemfile.lock","uv.lock","CODEOWNERS"],"protected_path_prefixes":[".github/",".agents/"],"title_prefix":"[Android Maintenance] "},"mentions":{"enabled":false},"missing_data":{},"missing_tool":{},"noop":{"max":1,"report-as-issue":"true"}}
+          GH_AW_SAFE_OUTPUTS_CONFIG_876e01d037e1f83a_EOF
      - name: Write Safe Outputs Tools
        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:107:6: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:55Z

+          {"create_pull_request":{"base_branch":"develop","draft":true,"github-token":"${{ secrets.GT_DAXMOBILE }}","labels":["agentic-maintenance"],"max":1,"max_patch_size":1024,"protected_files":["package.json","bun.lockb","bunfig.toml","deno.json","deno.jsonc","deno.lock","global.json","NuGet.Config","Directory.Packages.props","mix.exs","mix.lock","go.mod","go.sum","stack.yaml","stack.yaml.lock","pom.xml","build.gradle","build.gradle.kts","settings.gradle","settings.gradle.kts","gradle.properties","package-lock.json","yarn.lock","pnpm-lock.yaml","npm-shrinkwrap.json","requirements.txt","Pipfile","Pipfile.lock","pyproject.toml","setup.py","setup.cfg","Gemfile","Gemfile.lock","uv.lock","CODEOWNERS"],"protected_path_prefixes":[".github/",".agents/"],"title_prefix":"[Android Maintenance] "},"mentions":{"enabled":false},"missing_data":{},"missing_tool":{},"noop":{"max":1,"report-as-issue":"true"}}
+          GH_AW_SAFE_OUTPUTS_CONFIG_876e01d037e1f83a_EOF
      - name: Write Safe Outputs Tools
        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:10:7: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:55Z

+          {"create_pull_request":{"base_branch":"develop","draft":true,"github-token":"${{ secrets.GT_DAXMOBILE }}","labels":["agentic-maintenance"],"max":1,"max_patch_size":1024,"protected_files":["package.json","bun.lockb","bunfig.toml","deno.json","deno.jsonc","deno.lock","global.json","NuGet.Config","Directory.Packages.props","mix.exs","mix.lock","go.mod","go.sum","stack.yaml","stack.yaml.lock","pom.xml","build.gradle","build.gradle.kts","settings.gradle","settings.gradle.kts","gradle.properties","package-lock.json","yarn.lock","pnpm-lock.yaml","npm-shrinkwrap.json","requirements.txt","Pipfile","Pipfile.lock","pyproject.toml","setup.py","setup.cfg","Gemfile","Gemfile.lock","uv.lock","CODEOWNERS"],"protected_path_prefixes":[".github/",".agents/"],"title_prefix":"[Android Maintenance] "},"mentions":{"enabled":false},"missing_data":{},"missing_tool":{},"noop":{"max":1,"report-as-issue":"true"}}
+          GH_AW_SAFE_OUTPUTS_CONFIG_876e01d037e1f83a_EOF
      - name: Write Safe Outputs Tools
        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:7: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:55Z

          bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh

+      - name: Setup MCP Scripts Config
+        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:10: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:56Z

          bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh

+      - name: Setup MCP Scripts Config
+        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:68:10: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:56Z

+          chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs
+
+      - name: Setup MCP Scripts Tool Files
+        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:17:7: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:56Z

+          chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs
+
+      - name: Setup MCP Scripts Tool Files
+        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:7: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:56Z

+          GH_AW_MCP_SCRIPTS_PORT: ${{ steps.mcp-scripts-config.outputs.mcp_scripts_port }}
+          GH_AW_MCP_SCRIPTS_API_KEY: ${{ steps.mcp-scripts-config.outputs.mcp_scripts_api_key }}
+          ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }}
+        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:6:6: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:56Z

+
+      - name: Collect task IDs
+        id: collect
+        run: |


📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:5:30: Double quote to prevent globbing and word splitting [shellcheck]

daxmobile · 2026-04-29T05:11:58Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:1: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 90 in feb3698

run: ${RUNNER_TEMP}/gh-aw/actions/validate_multi_secret.sh ANTHROPIC_API_KEY 'Claude Code' https://github.github.com/gh-aw/reference/engines/#anthropic-claude-code

daxmobile · 2026-04-29T05:11:59Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 226 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/validate_prompt_placeholders.sh

daxmobile · 2026-04-29T05:12:00Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 231 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/print_prompt_summary.sh

daxmobile · 2026-04-29T05:12:01Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 280 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/create_gh_aw_tmp_dir.sh

daxmobile · 2026-04-29T05:12:01Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 282 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/configure_gh_for_ghe.sh

daxmobile · 2026-04-29T05:12:02Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 317 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/install_awf_binary.sh v0.25.4

daxmobile · 2026-04-29T05:12:03Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 331 in feb3698

run: bash ${RUNNER_TEMP}/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-firewall/agent:0.25.4 ghcr.io/github/gh-aw-firewall/api-proxy:0.25.4 ghcr.io/github/gh-aw-firewall/squid:0.25.4 ghcr.io/github/gh-aw-mcpg:v0.2.9 ghcr.io/github/github-mcp-server:v0.32.0 node:lts-alpine

daxmobile · 2026-04-29T05:12:04Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:10: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 333 in feb3698

run: |

daxmobile · 2026-04-29T05:12:04Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:4:7: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 333 in feb3698

run: |

daxmobile · 2026-04-29T05:12:05Z

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:9:6: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/android-maintenance-worker.lock.yml

Line 476 in feb3698

run: |

landomen mentioned this pull request Apr 15, 2026

PIR: Add new email flexibility action models #8232

Open

landomen mentioned this pull request Apr 15, 2026

PIR: Add state engine models for email flexibility #8233

Open

landomen commented Apr 15, 2026

View reviewed changes

landomen assigned karlenDimla Apr 15, 2026

landomen requested a review from karlenDimla April 15, 2026 12:15

cursor Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread .../src/main/java/com/duckduckgo/pir/impl/common/actions/ExecuteBrokerStepActionEventHandler.kt

Comment thread .../src/main/java/com/duckduckgo/pir/impl/common/actions/ExecuteBrokerStepActionEventHandler.kt

landomen mentioned this pull request Apr 15, 2026

PIR: Add handling of GenerateEmail action #8294

Open

karlenDimla reviewed Apr 28, 2026

View reviewed changes

Comment thread .../src/main/java/com/duckduckgo/pir/impl/common/actions/ExecuteBrokerStepActionEventHandler.kt Outdated

landomen force-pushed the feature/domen/pir-email-flexibility-step-action branch from 57b9781 to feb3698 Compare April 29, 2026 05:11

landomen requested review from malmstein and mikescamell as code owners April 29, 2026 05:11

daxmobile reviewed Apr 29, 2026

View reviewed changes

landomen added 3 commits April 29, 2026 07:12

Add broker step action handler logic

a0eaa26

Remove unused field

edfacf3

Remove unused field

b9ac7be

landomen force-pushed the feature/domen/pir-email-flexibility-step-action branch from feb3698 to b9ac7be Compare April 29, 2026 05:13

landomen force-pushed the feature/domen/pir-email-flexibility-state-engine-models branch from 53a3685 to 1c7b095 Compare April 29, 2026 05:13

Conversation

landomen commented Apr 15, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

UI changes

Uh oh!

landomen commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daxmobile left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

landomen commented Apr 15, 2026 •

edited by cursor Bot

Loading

landomen commented Apr 15, 2026 •

edited

Loading