Skip to content

Fix potential NPE in JdtUiUtils.selectType()#1456

Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:npe-jdt-utils
Apr 19, 2026
Merged

Fix potential NPE in JdtUiUtils.selectType()#1456
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:npe-jdt-utils

Conversation

@ptziegler
Copy link
Copy Markdown
Contributor

@ptziegler ptziegler commented Apr 18, 2026

The result of the selection dialog might be null. Use ArrayUtils to return null, instead of throwing an exception.

To stabilize the ActionGefTest, we wait one additional cycle for the "Select Type" dialog to show up.

@ptziegler ptziegler added this to the 1.24.0 milestone Apr 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 18, 2026

Test Results

 2 720 files  ±0   2 720 suites  ±0   11h 10m 6s ⏱️ + 8m 40s
 7 018 tests ±0   6 973 ✅ ±0   45 💤 ±0  0 ❌ ±0 
28 072 runs  ±0  27 882 ✅ ±0  190 💤 ±0  0 ❌ ±0 

Results for commit d880314. ± Comparison against base commit 743660b.

♻️ This comment has been updated with latest results.

The result of the selection dialog might be null. Use ArrayUtils to
return null, instead of throwing an exception.

To stabilize the ActionGefTest, we wait one additional cycle for the
"Select Type" dialog to show up.
@ptziegler ptziegler merged commit 90c58bc into eclipse-windowbuilder:master Apr 19, 2026
13 checks passed
@ptziegler ptziegler deleted the npe-jdt-utils branch April 19, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant