Skip to content

Fix potential NPE in JdtUiUtils.selectType() #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptziegler merged 1 commit into from
Apr 19, 2026
+5 −2
Merged

Fix potential NPE in JdtUiUtils.selectType() #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions org.eclipse.wb.core.java/src/org/eclipse/wb/internal/core/utils/jdt/ui/JdtUiUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011, 2025 Google, Inc. and others.
* Copyright (c) 2011, 2026 Google, Inc. and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License 2.0 which is available at
Expand Down Expand Up @@ -40,6 +40,8 @@
import org.eclipse.ui.editors.text.EditorsUI;
import org.eclipse.ui.texteditor.ChainedPreferenceStore;

import org.apache.commons.lang3.ArrayUtils;

/**
* Helper class for various JDT UI utils.
*
Expand Down Expand Up @@ -190,7 +192,7 @@ public static IType selectType(Shell shell, IJavaSearchScope scope, int style) t
dialog.setMessage(Messages.JdtUiUtils_selectTypeMessage);
// open dialog
if (dialog.open() == Window.OK) {
return (IType) dialog.getResult()[0];
return (IType) ArrayUtils.get(dialog.getResult(), 0);
}
// no type selected
return null;
Expand Down
1 change: 1 addition & 0 deletions org.eclipse.wb.tests/src/org/eclipse/wb/tests/designer/swing/model/bean/ActionGefTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ public void run() throws Exception {
entry.initialize(m_viewerCanvas, panel);
Tool tool = entry.createTool();
m_viewerCanvas.getEditDomain().setActiveTool(tool);
waitEventLoop(0);
}
}, new FailableConsumer<>() {
@Override
Expand Down
Loading