Skip to content

playground: fix tici s3 default config#2625

Merged
xhebox merged 1 commit into
pingcap:feature/ftsfrom
Lloyd-Pottiger:fix-s3-config
Oct 30, 2025
Merged

playground: fix tici s3 default config#2625
xhebox merged 1 commit into
pingcap:feature/ftsfrom
Lloyd-Pottiger:fix-s3-config

Conversation

@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot requested review from breezewish and nexustar October 30, 2025 02:36
@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/fts@519850b). Learn more about missing BASE report.

⚠️ Current head d6d2f51 differs from pull request most recent head 298e235

Please upload reports for the commit 298e235 to get more accurate results.

Files with missing lines Patch % Lines
components/playground/instance/tici_meta_config.go 0.00% 6 Missing ⚠️
...mponents/playground/instance/tici_worker_config.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             feature/fts    #2625   +/-   ##
==============================================
  Coverage               ?   45.47%           
==============================================
  Files                  ?      372           
  Lines                  ?    38523           
  Branches               ?        0           
==============================================
  Hits                   ?    17518           
  Misses                 ?    18867           
  Partials               ?     2138           
Flag Coverage Δ
tiup 33.96% <ø> (?)
unittest 16.35% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xhebox xhebox merged commit a876f42 into pingcap:feature/fts Oct 30, 2025
6 of 7 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-s3-config branch October 30, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants