Skip to content

playground: fix tici s3 default config #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xhebox merged 1 commit into from
Oct 30, 2025
Merged

playground: fix tici s3 default config #2625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/playground/instance/tici_meta_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ func (inst *TiCIInstance) getMetaConfig() map[string]any {
tidbServers = append(tidbServers, db.DSN())
}
config["tidb_server.dsns"] = tidbServers
defaultS3Config := getDefaultTiCIMetaS3Config()
config["s3.endpoint"] = defaultS3Config.Endpoint
config["s3.access_key"] = defaultS3Config.AccessKey
config["s3.secret_key"] = defaultS3Config.SecretKey
config["s3.bucket"] = defaultS3Config.Bucket
config["s3.prefix"] = defaultS3Config.Prefix
return config
}

Expand Down
6 changes: 6 additions & 0 deletions components/playground/instance/tici_worker_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ package instance

func (inst *TiCIInstance) getWorkerConfig() map[string]any {
config := make(map[string]any)
defaultS3Config := getDefaultTiCIMetaS3Config()
config["s3.endpoint"] = defaultS3Config.Endpoint
config["s3.access_key"] = defaultS3Config.AccessKey
config["s3.secret_key"] = defaultS3Config.SecretKey
config["s3.bucket"] = defaultS3Config.Bucket
config["s3.prefix"] = defaultS3Config.Prefix
return config
}

Expand Down
Loading